Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions app/Models/Project.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
* @property int $emailtesttimingchanged
* @property int $emailbrokensubmission
* @property int $emailredundantfailures
* @property int $showipaddresses
* @property string $cvsviewertype
* @property int $testtimestd
* @property int $testtimestdthreshold
Expand Down Expand Up @@ -77,7 +76,6 @@ class Project extends Model
'emailtesttimingchanged',
'emailbrokensubmission',
'emailredundantfailures',
'showipaddresses',
'cvsviewertype',
'testtimestd',
'testtimestdthreshold',
Expand Down
3 changes: 0 additions & 3 deletions app/cdash/app/Model/Project.php
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ class Project
public $TestTimeMaxStatus;
public $EmailMaxItems = 5;
public $EmailMaxChars = 255;
public $ShowIPAddresses = 0;
public $DisplayLabels = 0;
public $ShareLabelFilters = 0;
public $ViewSubProjectsLink = 0;
Expand Down Expand Up @@ -130,7 +129,6 @@ public function Save(): bool
'emailtesttimingchanged' => (int) $this->EmailTestTimingChanged,
'emailbrokensubmission' => (int) $this->EmailBrokenSubmission,
'emailredundantfailures' => (int) $this->EmailRedundantFailures,
'showipaddresses' => (int) $this->ShowIPAddresses,
'displaylabels' => (int) $this->DisplayLabels,
'sharelabelfilters' => (int) $this->ShareLabelFilters,
'viewsubprojectslink' => (int) $this->ViewSubProjectsLink,
Expand Down Expand Up @@ -219,7 +217,6 @@ public function Fill(): void
$this->EmailTestTimingChanged = $project->emailtesttimingchanged;
$this->EmailBrokenSubmission = $project->emailbrokensubmission;
$this->EmailRedundantFailures = $project->emailredundantfailures;
$this->ShowIPAddresses = $project->showipaddresses;
$this->DisplayLabels = $project->displaylabels;
$this->ShareLabelFilters = $project->sharelabelfilters;
$this->ViewSubProjectsLink = $project->viewsubprojectslink;
Expand Down
1 change: 0 additions & 1 deletion app/cdash/tests/test_actualtrilinossubmission.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public function createProjectWithName($project)
'Name' => $project,
'Description' => $project . ' project created by test code in file [' . __FILE__ . ']',
'EmailBrokenSubmission' => '1',
'ShowIPAddresses' => '1',
'DisplayLabels' => '1',
'NightlyTime' => '21:00:00 America/New_York',
'ShareLabelFilters' => '1'];
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<?php

use Illuminate\Database\Migrations\Migration;

return new class extends Migration {
public function up(): void
{
DB::statement('ALTER TABLE project DROP COLUMN showipaddresses');
}

public function down(): void
{
}
};
6 changes: 0 additions & 6 deletions phpstan-baseline.neon
Original file line number Diff line number Diff line change
Expand Up @@ -11607,12 +11607,6 @@ parameters:
count: 1
path: app/cdash/app/Model/Project.php

-
rawMessage: Property CDash\Model\Project::$ShowIPAddresses has no type specified.
identifier: missingType.property
count: 1
path: app/cdash/app/Model/Project.php

-
rawMessage: Property CDash\Model\Project::$ShowTestTime has no type specified.
identifier: missingType.property
Expand Down
38 changes: 0 additions & 38 deletions resources/js/vue/components/EditProject.vue
Original file line number Diff line number Diff line change
Expand Up @@ -1646,44 +1646,6 @@
</span>
</td>
</tr>
<tr>
<td />
<td>
<div align="right">
<strong>Show site IP addresses:</strong>
</div>
</td>
<td>
<input
v-model="cdash.project.ShowIPAddresses"
type="checkbox"
name="showIPAddresses"
true-value="1"
false-value="0"
@change="cdash.changesmade = true"
@focus="showHelp('showSiteIPAddresses_help')"
>
<a
href="http://www.cdash.org/Wiki/CDash:Administration#Creating_a_project"
target="blank"
>
<img
:src="$baseURL + '/img/help.gif'"
border="0"
@mouseover="showHelp('showSiteIPAddresses_help')"
>
</a>
<span
id="showSiteIPAddresses_help"
class="help_content"
>
<b>Show Site IP Addresses</b>
<br>
Enable/Disable the display of IP addresses of the sites
submitting to this project.
</span>
</td>
</tr>
<tr>
<td />
<td>
Expand Down
1 change: 0 additions & 1 deletion tests/Spec/edit-project.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ beforeEach(() => {
Public: 1,
ShareLabelFilters: 0,
ShowCoverageCode: 1,
ShowIPAddresses: 0,
ShowTestTime: 0,
TestTimeMaxStatus: 3,
TestTimeStd: 4,
Expand Down