Skip to content

Conversation

@mprokopc
Copy link

@mprokopc mprokopc commented Jan 23, 2025

What this PR does / why we need it:

Adding ability to change gateway-operator host network value by helm values. it's required when calico cni is used

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@mprokopc mprokopc requested a review from a team as a code owner January 23, 2025 10:39
@CLAassistant
Copy link

CLAassistant commented Jan 23, 2025

CLA assistant check
All committers have signed the CLA.

@mprokopc mprokopc changed the title fix(gateway-operator): changeable host network value for gateway oper… fix(gateway-operator): changeable host network value for gw-operator Jan 23, 2025
@mprokopc
Copy link
Author

@pmalek could you review this PR, please?

Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in reviewing this. This change looks good. Please add a changelog entry in https://github.com/Kong/charts/blob/main/charts/gateway-operator/CHANGELOG.md

Also, please make sure to rebase on the latest tip of main. I'm pretty sure the CI should trigger then

@pmalek
Copy link
Member

pmalek commented Apr 14, 2025

@mprokopc Just checking in, do you still want to contribute this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants