-
Notifications
You must be signed in to change notification settings - Fork 2
Geometry descriptions for ECAL-E and ECAL-P #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
originally from CaloTB and LUXETracker; new `stave` element as the subunit of a slice; passed formality check; TODO: .xml definition files need to be merged/cleaned up
sub-slice element properly implemented (kudos to Thomas); the element name changed from `stave` to `module` to avoid conflict; slice module is directly put into layer; ECALe_luxe visualization in png and root files; CMakeLists updated to solve the `lib' directory problem;
tmadlener
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for opening this. I had a brief look now only and in general this looks good, I think. There are a few more detailed questions / comments below.
Are the binary files necessary (i.e. the .png and .root files)? It looks like they are not used by the README and I would like to keep binary files out of git history if possible. If they are necessary, we can leave them in of course.
|
Some more comments to the top level TODO list items:
I think for now this is perfectly fine to this downstream with some processor or algorithm. This should be fairly straight forward to change later (even if it is a bit of work). I think it would be more important to have a combined geometry with a tracker and a calorimeter in DD4hep for now.
Could we have a test simulation as part of a test that we could run in CI? We would probably need some inputs, but we can also just run a particle gun for some very basic checks. We have some tests for the tracker already: https://github.com/LUXEsoftware/luxegeo/blob/main/tests/CMakeLists.txt
Also here, I would be in favor of merging this in a way that standalone simulation with the individual calorimeters work. We can then do the homogenization and cleanup to make things consistent in a combined tracker + calorimeter geometry in a follow up PR. |
they are workaround for DD4hep v00-14 and older; Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
Similar views can be get from the DD4hep geometry directly
Historical .xml files removed;
in slice_vol, module_vol should be put at z==0; module name correction;
Implementation of isolated ECAL-P (prototype by FCAL) and ECAL-E (prototype by CALICE/DRD-Calo).
Feature
LUXEEcaldetector type;key4geo/detector/CaloTB;ECALe_luxe_2512.xmlECALe_luxe_v1.xmlused in ECAL-NPOD study in 2024-25;ECALe_luxe_v2.xmlare added, but the v1 geometry is kept;ECALp_luxe_2512.xml;ECALe_luxe_2512.xmlwith ECAL-P prototype geometrical design during TB2025;To-do list
Cell ID in readouts section;Need help to understand how are the segments added (per module in our case? or per slice?)Follow-up (naive) analyses on the new implementation;The latest analysis usesECALe_luxe_v1.xml;Materials_v1.xmlandmaterials.xml;Merge documents for ECAL to main README.md (?)