Skip to content

Conversation

@Darren52BT
Copy link
Contributor

This PR implements the view only version of the profile page.

Changes:

  • added a boolean called viewOnly to the Profile type that is passed into the profile's Page component, and this in turn is passed down to every component that needs to be adapted to view only.
  • used this boolean to perform conditional rendering between view only/editable components
  • added a boolean parameterisSecond to ProfileAccordionCombobox that represents whether it is the second combobox in a accordion to implement the difference in colors shown here
    image
  • added another color to the theme palette called input.borderActive for the Biography component's border

What You Should See

image
image

Copy link
Contributor

@JRSiwiecki JRSiwiecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really small misc changes and questions that I have, this looks good though 💯 ping me when you get a chance to respond

Copy link
Contributor

@JRSiwiecki JRSiwiecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants