Skip to content
This repository was archived by the owner on Apr 19, 2022. It is now read-only.

Conversation

@HFAsif
Copy link

@HFAsif HFAsif commented Nov 23, 2020

can you check this url => https://www.youtube.com/watch?v=nhZvvdRSQaE
getting exception

can you check this url => https://www.youtube.com/watch?v=nhZvvdRSQaE 
getting exception
@LinPolly
Copy link
Owner

Fix by 439131b this video can't embed.

@HFAsif
Copy link
Author

HFAsif commented Dec 2, 2020

thanks a lot for this awesome fixed ,

@HFAsif
Copy link
Author

HFAsif commented Jul 26, 2021

thanks again all fixed

@HFAsif
Copy link
Author

HFAsif commented Oct 27, 2021

hi
now i am facing a problem , download speed so slower downloading but when download by browser its so fast
can you check it please
test url
https://www.youtube.com/watch?v=WNeLUngb-Xg

download speed so slow

@LinPolly
Copy link
Owner

LinPolly commented Nov 4, 2021

7ecdd51
fix download speed so slow
Decipherer.cs Fix From DownloadUrl uri param 'n' use NiL.JS to easy run some decipher.
yt_dlp/extractor/youtube.py#L1882
yt_dlp/jsinterp.py#L489

@HFAsif
Copy link
Author

HFAsif commented Nov 6, 2021

starting point i am getting some exception
copied 1 line only
at NiL.JS.ExceptionHelper.Throw(Error error, CodeNode exceptionMaker, String code)
at NiL.JS.ExceptionHelper.ThrowVariableIsNotDefined(String variableName, CodeNode exceptionMaker)
at NiL.JS.Expressions.Variable.Evaluate(Context context)
at NiL.JS.Expressions.Call.Evaluate(Context context)
at NiL.JS.Statements.CodeBlock.evaluateLines(Context context, Int32 i, Boolean clearSuspendData)
at NiL.JS.Statements.CodeBlock.Evaluate(Context context)
at NiL.JS.Core.Context.Eval(String code, JSValue thisBind, Boolean suppressScopeCreation)
at YoutubeExtractor.Decipherer.NDescramble(String js, String n_param) in C:\Users\admin\Desktop\YoutubeExtractor-master\YoutubeExtractor\YoutubeExtractor\Decipherer.cs:line 110
at YoutubeExtractor.DownloadUrlResolver.GetNDescramble(String js, String signature) in C:\Users\admin\Desktop\YoutubeExtractor-master\YoutubeExtractor\YoutubeExtractor\DownloadUrlResolver.cs:line 200
at YoutubeExtractor.DownloadUrlResolver.DecryptDownloadUrlNParam(VideoInfo videoInfo, String js) in C:\Users\admin\Desktop\YoutubeExtractor-master\YoutubeExtractor\YoutubeExtractor\DownloadUrlResolver.cs:line 66
NiL.JS.Core.JSException: ReferenceError: Variable "sha" is not defined at (1:1*3)
at NiL.JS.ExceptionHelper.Throw(Error error, CodeNode exceptionMaker, String code)
at NiL.JS.ExceptionHelper.ThrowVariableIsNotDefined(String variableName, CodeNode exceptionMaker)
at NiL.JS.Expressions.Variable.Evaluate(Context context)
at NiL.JS.Expressions.Call.Evaluate(Context context)
at NiL.JS.Statements.CodeBlock.evaluateLines(Context context, Int32 i, Boolean clearSuspendData)
at NiL.JS.Statements.CodeBlock.Evaluate(Context context)
at NiL.JS.Core.Context.Eval(String code, JSValue thisBind, Boolean suppressScopeCreation)
at YoutubeExtractor.Decipherer.NDescramble(String js, String n_param) in C:\Users\admin\Desktop\YoutubeExtractor-master\YoutubeExtractor\YoutubeExtractor\Decipherer.cs:line 110
at YoutubeExtractor.DownloadUrlResolver.GetNDescramble(String js, String signature) in C:\Users\admin\Desktop\YoutubeExtractor-master\YoutubeExtractor\YoutubeExtractor\DownloadUrlResolver.cs:line 200
at YoutubeExtractor.DownloadUrlResolver.DecryptDownloadUrlNParam(VideoInfo videoInfo, String js) in C:\Users\admin\Desktop\YoutubeExtractor-master\YoutubeExtractor\YoutubeExtractor\DownloadUrlResolver.cs:line 66

sometime fast sometime slow , i just see 1 time only it download so fast , but tried many time same result slow speed ,
can check please

@LinPolly
Copy link
Owner

LinPolly commented Nov 7, 2021

7e6764b
Fix Decipherer.cs#L103 residual qha test regex string

@HFAsif
Copy link
Author

HFAsif commented Nov 7, 2021

awesome fixed in my pc now i get 6 mb download speed .
thank you for this awesome fixed .

@mixail167
Copy link

Hello, I suggest implementing interface IClonable in class VideoInfo.

   public object Clone()
    {
        return new VideoInfo(this)
        {
            AverageBitrate = AverageBitrate,
            DownloadUrl = DownloadUrl,
            FileSize = FileSize,
            FormatNote = FormatNote,
            FPS = FPS,
            Height = Height,
            HtmlPlayerVersion = HtmlPlayerVersion,
            RequiresDecryption = RequiresDecryption,
            Title = Title,
            Width = Width
        };
    }

I found this implementation useful in my program.

@HFAsif
Copy link
Author

HFAsif commented Jan 4, 2022

if possible please see this also
can not download age restricted video
https://www.youtube.com/watch?v=z-Yb6FJv7qQ

@HFAsif
Copy link
Author

HFAsif commented Feb 2, 2022

download speed so slower again but when download by browser its so fast
https://www.youtube.com/watch?v=nhZvvdRSQaE

@HFAsif
Copy link
Author

HFAsif commented Feb 11, 2022

i think it need more update framwork

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants