-
Notifications
You must be signed in to change notification settings - Fork 74
feat: Syslog backend #2985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Syslog backend #2985
Conversation
7e8eedd to
2561f2a
Compare
2561f2a to
457e702
Compare
|
|
||
| case Pool.send(pool, content) do | ||
| :ok -> messages | ||
| {:error, reason} -> fail_batch(messages, reason) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we need to add handle_failed and retry there. We can keep something like :attempt in the ack metadata to stop retrying after attempt > 3 or something like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets default to 1 retry which is what all backends are standardizing to
Yes lets use a config for it since it is not widely supported
no don't expose those. we should manage them automatically under the hood.
Yes, we can do that, should be an either/or validation. |
Continues from #2067
TODOs
Questions
Should this backend expose the Broadway topology parameters in the backend / application configuration?host,port, andtlsfields, could it be a connection URI (e.g.,tcp://host:port, orssl://host:portortls://host:port)? It might even contain cipher keys/certs/... like in psql-style urls.