Reintroduce dynamic linking support #908
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, only the include directories were passed to forum and gyre, disregarding any compile flags set by the forum and gyre makefiles. Instead, set all compile flags used by mesa, but set the language standard to Fortran 2018
Member
Author
|
@rhdtownsend I am currently forcing all compile flags for the normal MESA modules onto forum and gyre, as I need to propagate the linker and include flags. Once gyre and forum switch to pkg-config for their dependencies, I can remove that part. Alternatively, it would also be possible to patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reintroduces proper dynamic linking support for the new build system.
Remaining tasks:
make installor similar commands work (useful forpymesa). The currently implementation usesrpathto allow the libraries to find each other. This will need to be fixed withchrpathorpatchelfon install. Alternatively,pymesawould need to be changed to look for modules and libraries in the build folder, if there is no need otherwise to support amake installcommand.This is the last main part of #662.