Skip to content

Conversation

@davidsbatista
Copy link
Collaborator

@davidsbatista davidsbatista commented Aug 22, 2025

Related Issues

Proposed Changes:

  • Adding a min_overlap_percentage: float = 1.0 to the PartialEvaluation and EntityTypeEvaluation evaluation strategies.
  • A partial match is only considered if the match overlap is equal or abve the defined min_overlap_percentage

How did you test it?

  • local unit tests + CI tests

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

Copy link
Collaborator

@ivyleavedtoadflax ivyleavedtoadflax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition LGTM! 🚀

@davidsbatista
Copy link
Collaborator Author

thanks @ivyleavedtoadflax - I will merge it later, and do a 1.1.0 release - or go ahead if you feel like it

@davidsbatista davidsbatista merged commit 502db83 into main Sep 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants