Skip to content

Conversation

@davidsbatista
Copy link
Collaborator

@davidsbatista davidsbatista commented May 18, 2025

CI/CD

  • Replaced old CI workflow with new multi-platform workflow (ubuntu, windows, macos)
  • Updated GitHub Actions to latest versions
  • Switched from Make to Hatch for build and development

Development & Testing

  • Moved all tool configurations to pyproject.toml
  • Updated Python version to 3.11
  • Added pytest-cov for coverage reporting

Documentation

  • Added CONTRIBUTING.md with guidelines
  • Added commit message and changelog conventions

Dependencies

  • Updated dev dependencies (removed flake8, added pytest-cov)
  • Updated tool versions (black, coverage, mypy)

Code Structure

  • Cleaned up imports in example files
  • Removed setup.cfg in favor of pyproject.toml

@davidsbatista davidsbatista marked this pull request as ready for review May 18, 2025 22:06
@davidsbatista davidsbatista requested a review from Copilot May 18, 2025 22:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces Make-based workflows with Hatch, updates type hints to built-in generics, and modernizes CI configuration while cleaning up configs and adding testing/docs.

  • Switched CI from Make to Hatch across Ubuntu, Windows, and macOS.
  • Migrated all type annotations from typing imports to built-in generic syntax.
  • Consolidated tooling config into pyproject.toml and removed legacy config files.

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/test_reporting.py Minor import spacing fix in test file
src/nervaluate/utils.py Updated type hints to Python 3.10+ built-in generics
src/nervaluate/reporting.py Switched exception type, updated type hints, refined loops
src/nervaluate/evaluate.py Reordered imports, switched to built-in generics, added strict zip
src/nervaluate/init.py Reordered exports for consistency
setup.cfg Removed in favor of pyproject.toml
pyproject.toml Added Hatch envs, pytest-cov, coverage, black, mypy, pylint configs
pylint.cfg Removed legacy config file
examples/example_no_loader.py Consolidated imports in example
.github/workflows/CI-checks.yml New multi-platform Hatch-based workflow
Comments suppressed due to low confidence (1)

src/nervaluate/utils.py:1

  • New utility functions (split_list, conll_to_spans, list_to_spans, collect_named_entities) lack corresponding unit tests; consider adding tests to verify their behavior and cover edge cases.
def split_list(token: list[str], split_chars: list[str] | None = None) -> list[list[str]]:

davidsbatista and others added 3 commits May 19, 2025 00:38
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@davidsbatista davidsbatista merged commit 8cdd357 into main May 18, 2025
3 checks passed
@davidsbatista davidsbatista deleted the adding-hatch-as-project-manager branch May 18, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants