-
Notifications
You must be signed in to change notification settings - Fork 25
Adding hatch as project manager #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces Make-based workflows with Hatch, updates type hints to built-in generics, and modernizes CI configuration while cleaning up configs and adding testing/docs.
- Switched CI from Make to Hatch across Ubuntu, Windows, and macOS.
- Migrated all type annotations from
typingimports to built-in generic syntax. - Consolidated tooling config into
pyproject.tomland removed legacy config files.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_reporting.py | Minor import spacing fix in test file |
| src/nervaluate/utils.py | Updated type hints to Python 3.10+ built-in generics |
| src/nervaluate/reporting.py | Switched exception type, updated type hints, refined loops |
| src/nervaluate/evaluate.py | Reordered imports, switched to built-in generics, added strict zip |
| src/nervaluate/init.py | Reordered exports for consistency |
| setup.cfg | Removed in favor of pyproject.toml |
| pyproject.toml | Added Hatch envs, pytest-cov, coverage, black, mypy, pylint configs |
| pylint.cfg | Removed legacy config file |
| examples/example_no_loader.py | Consolidated imports in example |
| .github/workflows/CI-checks.yml | New multi-platform Hatch-based workflow |
Comments suppressed due to low confidence (1)
src/nervaluate/utils.py:1
- New utility functions (
split_list,conll_to_spans,list_to_spans,collect_named_entities) lack corresponding unit tests; consider adding tests to verify their behavior and cover edge cases.
def split_list(token: list[str], split_chars: list[str] | None = None) -> list[list[str]]:
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CI/CD
Development & Testing
Documentation
Dependencies
Code Structure