-
Notifications
You must be signed in to change notification settings - Fork 25
refact: big refactoring #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…er true or pred data
|
Hi @ivyleavedtoadflax! I did a big refactoring on this code - I think it deserved it. I still kept the old functionality. I suggest we make a release with some warnings for upcoming breaking changes - and after 1 or 2 weeks we release this new version. What do you think? |
|
Great @davidsbatista, yes I think it deserved it. I will give this a review, but agree with the idea of a release warning about breaking changes in the meantime |
ivyleavedtoadflax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks, good, much tidier! LGTM 🥳
|
@davidsbatista looks good, happy to approve. Let's go ahead with the warning about breaking changes in the meantime, and you can approve once we've given a couple of weeks warning. |
|
@ivyleavedtoadflax adding deprecation warnings here |
|
removing old code, so that only the new version works - @ivyleavedtoadflax let me know when you release the current |
Done |
|
somehow pip index is not showing the last release, only one from last year is availalbe |
Overview
Key Changes
Code Restructuring
Code Quality Improvements
Verification
The
compare_versions.pyscript has been added to verify that the old and new code produce identical output content. While the results are functionally equivalent, the new code provides better visualisation for the reporting based on indicesTesting