Fixed an issue where webView continues playing after closing the QuickLook window or switching to another file #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #146, when previewing WebM files, the audio/video persists even after the QuickLook session terminates (including closing the window or navigating to another file).
This occurs because the QuickLook extension fails to explicitly pause media playback.
This fix implements a polling mechanism (timer) to monitor the visibility of the QuickLook window and detect file transitions every 0.1s. It ensures the webView automatically pauses or resets when the preview is no longer active.
Maybe using a timer isn't the best solution, but I can't think of any better idea now.