tokio-postgres: use tokio mpsc for CopyBoth streams
#30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tokio implementation of mpsc channels seems to be more sophisticated and performant than the one in futures_channel. Since the channels used by the CopyBoth streams transfer a large amount of data during replication this PR switches the implementation to tokio. This PR doesn't yet alter the size of the channels in order to do an apples to apples comparison. A subsequent test should be performed with larger buffers between the producer and consumer tasks. Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
|
Hello, issues are closed so I'm commenting here. Can master be synced with upstream? |
Author
|
hi @reneleonhardt, this repo is now synced with upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tokio implementation of mpsc channels seems to be more sophisticated and performant than the one in futures_channel. Since the channels used by the CopyBoth streams transfer a large amount of data during replication this PR switches the implementation to tokio.
This PR doesn't yet alter the size of the channels in order to do an apples to apples comparison. A subsequent test should be performed with larger buffers between the producer and consumer tasks.