Added nullability annotations and nil defaults. #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Sorry it took some time, Could you please fix the conflicts so I can merge your helpful changes? Thanks! |
Author
|
Looking at the Travis-CI build output, it seems like the compiler is not understanding the “nullable” annotation. The SDK needs to be at least iOS 8.3 for it to work. Is there any way to update Travis-CI to use that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added nullability annotations for use in Swift (no more ugly !). I also allowed nil to be used as a default value and in the case of the font names, the default or an unfound font will use the system font (no more crashing in the Interface Builder). Font sizes < 0 revert to the default size, as all values less than 0.0 are not allowed according to the documentation. I had to push some default settings out of the view constructor but I believe this is an acceptable loss: what the default settings are is not important to the user.