Skip to content

added support for service.deploy.resources.limits #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TomasLudvik wants to merge 1 commit into
base: main
Choose a base branch
from
Open

added support for service.deploy.resources.limits #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions Sources/Container-Compose/Commands/ComposeUp.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,13 +352,24 @@ public struct ComposeUp: AsyncParsableCommand, @unchecked Sendable {
runCommandArgs.append(contentsOf: ["--platform", "\(platform)"])
}

// Handle 'deploy' configuration (note that this tool doesn't fully support it)
if service.deploy != nil {
print("Note: The 'deploy' configuration for service '\(serviceName)' was parsed successfully.")
print(
"However, this 'container-compose' tool does not currently support 'deploy' functionality (e.g., replicas, resources, update strategies) as it is primarily for orchestration platforms like Docker Swarm or Kubernetes, not direct 'container run' commands."
)
print("The service will be run as a single container based on other configurations.")
// Handle 'deploy' configuration - apply resource limits
if let deploy = service.deploy {
// Apply memory limit
if let memoryLimit = deploy.resources?.limits?.memory {
runCommandArgs.append("-m")
runCommandArgs.append(memoryLimit)
}

// Apply CPU limit
if let cpuLimit = deploy.resources?.limits?.cpus {
runCommandArgs.append("-c")
runCommandArgs.append(cpuLimit)
}

// Log unsupported deploy features
if deploy.mode != nil || deploy.replicas != nil || deploy.restart_policy != nil {
print("Note: The 'deploy' configuration for service '\(serviceName)' includes features (mode, replicas, restart_policy) that are not supported by this tool.")
}
}

// Add detach flag if specified on the CLI
Expand Down