fix: support relative paths in host path volumes #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert relative paths (e.g., ./data/postgres) to normalized absolute paths - Use URL.standardizedFileURL to remove ./ and ../ components - Pass absolute paths to container run -v command instead of relative paths - Fixes issue where container tool incorrectly treats relative paths as named volume names The container tool requires absolute paths for bind mounts. Previously, relative paths like './data/postgres' were passed directly, causing the tool to validate them as named volume names (which must match ^[A-Za-z0-9][A-Za-z0-9_.-]*$), resulting in validation errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The container tool requires absolute paths for bind mounts. Previously, relative paths like './data/postgres' were passed directly, causing the tool to validate them as named volume names (which must match ^[A-Za-z0-9][A-Za-z0-9_.-]*$), resulting in validation errors.
fix #4