Fix/restore file id in parser #648
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 8, 2025 15:42
Recent changes to rebuild_from_source removed original_part, causing file_id to be lost during memory transfer. This resulted in null source_doc_id in logs. This fix restores file_id by falling back to the info dictionary.
In _process_transfer_multi_modal_data, file_ids were not explicitly passed from raw_node.metadata to the info dictionary. This prevented file_content_parser from accessing the file_ids during memory transfer, leading to null source_doc_id in logs. This commit ensures file_ids are properly propagated.
1. file_content_parser: Persist file_id in SourceMessage and restore it in rebuild_from_source to prevent data loss during object reconstruction. 2. multi_modal_struct: Fix indentation and ensure file_ids are propagated via info dict as a safety fallback.
tangg555
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary: (summary)
Fix: #(issue)
Docs Issue/PR: (docs-issue-or-pr-link)
Reviewer: @(reviewer)
Checklist: