Skip to content

Fix amazonaws base url #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JanCaha merged 1 commit into from
Jul 24, 2025
Merged

Fix amazonaws base url #41

JanCaha merged 1 commit into from
Jul 24, 2025

Conversation

@JanCaha
Copy link
Collaborator

@JanCaha JanCaha commented Jun 19, 2025

construct base_url differently if region is set and endpoint contains amazonaws

Fixes #39

@JanCaha JanCaha mentioned this pull request Jun 19, 2025
Closed
@tomasMizera tomasMizera requested a review from varmar05 June 19, 2025 07:31
varmar05
varmar05 reviewed Jun 19, 2025
View reviewed changes
@tomasMizera tomasMizera requested a review from varmar05 July 24, 2025 10:55
@JanCaha JanCaha merged commit 60268a9 into main Jul 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@varmar05 varmar05 varmar05 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ext_url construction fails for S3 buckets outside us-east-1

3 participants

@JanCaha @varmar05