-
-
Notifications
You must be signed in to change notification settings - Fork 261
chore: integrate storageService with tokenListController #7413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sahar-fehri
wants to merge
21
commits into
main
Choose a base branch
from
chore/integrate-storage-service-with-tokenListController
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: integrate storageService with tokenListController #7413
sahar-fehri
wants to merge
21
commits into
main
from
chore/integrate-storage-service-with-tokenListController
+1,283
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahar-fehri
commented
Dec 9, 2025
| tokensChainsCache: { | ||
| includeInStateLogs: false, | ||
| persist: true, | ||
| persist: false, // Persisted separately via StorageService |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making this false to block disk writes
7 tasks
…oading and saving
Prithpal-Sooriya
previously approved these changes
Dec 16, 2025
salimtb
previously approved these changes
Dec 16, 2025
…tchTokenList calls
andrepimenta
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimizes TokenListController storage to reduce write amplification by persisting tokensChainsCache via StorageService using per-chain files instead of a single monolithic state property.
Related: https://github.com/MetaMask/metamask-mobile/pull/22943/files
Related: https://github.com/MetaMask/decisions/pull/110
Related: #7192
Explanation
The tokensChainsCache (~5MB total, containing token lists for all chains) was persisted as part of the controller state. Every time a single chain's token list was updated (~100-500KB), the entire ~5MB cache was rewritten to disk, causing:
Solution
Per-Chain File Storage:
Each chain's cache is now stored in a separate file (e.g., tokensChainsCache:0x1, tokensChainsCache:0x89)
Only the updated chain (~100-500KB) is written on each token fetch, reducing write operations by ~90-95%
All chains are loaded in parallel at startup to maintain compatibility with TokenDetectionController
Key Changes:
References
Checklist
Note
TokenListController now persists
tokensChainsCacheto StorageService as per‑chain files with initialization load/migration, safer async clearing, and comprehensive tests; adds storage-service dependency and updates metadata/types.tokensChainsCacheviaStorageServiceusing per‑chain keys (tokensChainsCache:<chainId>); stop framework persistence (persist: false).clearingTokenListData()to remove all per‑chain files (handles partial failures withPromise.allSettled).StorageService:getItem|setItem|removeItem|getAllKeys.clearingTokenListData(); minor type fixes.@metamask/storage-serviceand TypeScript project references; update yarn.lock.Written by Cursor Bugbot for commit eb78626. This will update automatically on new commits. Configure here.