chore: Update vite & vitest dependencies to latest versions #717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirtimid
changed the title
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
Contributor
Author
|
@SocketSecurity ignore-all |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
sirtimid
force-pushed
the
sirtimid/deps-vitest-4
branch
from
0129d08 to
65ee112
Compare
rekmarks
reviewed
Jan 5, 2026
Comment on lines
+134
to
+135
| 'vitest/no-alias-methods': 'off', | ||
| 'vitest/prefer-called-exactly-once-with': 'off', |
Member
There was a problem hiding this comment.
I assume these are new. Are they good? Should we add TODOs to enable them?
Contributor
Author
There was a problem hiding this comment.
I added a comment that these are temporary and should be removed when @metamask/eslint-config-vitest is updated
packages/cli/src/file.test.ts
Outdated
Comment on lines
27
to
31
| beforeEach(() => { | ||
| mocks.access.mockClear(); | ||
| mocks.lstat.mockClear(); | ||
| mocks.copyFile.mockClear(); | ||
| }); |
Member
There was a problem hiding this comment.
We now have to do some of this manually? Seems like an unfortunate regression.
Contributor
Author
There was a problem hiding this comment.
Ah I can add clearMocks: true to prevent this (In Vitest 4, restoreMocks only restores spies created with vi.spyOn(), not mocks created with vi.fn()) I'll change it.
Comment on lines
+671
to
+672
| // Make the mocked MessageQueue behave like a real FIFO queue so the test | ||
| // models actual behavior: failed sends enqueue messages, and flush dequeues them. |
Member
There was a problem hiding this comment.
This mock implementation is pretty complex and makes the test harder to understand. Can we move the setup into a function stored elsewhere in the file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates all vite-related dependencies (vite, vitest, @vitest/, @vitejs/, jsdom) across the monorepo and migrates to Vitest 4.0. Fixes breaking changes including browser testing configuration for the streams package, constructor mocks (changed arrow functions to function declarations), mock state persistence (added mockClear in beforeEach), and ESLint errors related to promise-returning mocks.
Note
Modernizes test/build stack and applies required migrations for Vitest 4.
vitestto^4.0.16,viteto^7.3.0, updates@vitest/*,@vitejs/*,vite-tsconfig-paths, andjsdomacross packagesstreamsto Vitest Browser with Playwright (@vitest/browser-playwright) and updates config (vitest.config.ts) accordinglytoThrowwithtoThrowError, convert constructor mocks tofunctionimplementations, addbeforeEachmockClear, and adjust call assertions (e.g.,haveBeenCalledExactlyOnceWith)kernel-shims/endoify-repairand setsLOCKDOWN_ERROR_TRAPPING: 'none'in Node E2E Vitest config to avoid process.exit during testsvitest/*rules) and tweaks timeouts/thresholds in tests and rootvitest.config.tsWritten by Cursor Bugbot for commit b6d2104. This will update automatically on new commits. Configure here.