Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
"@lavamoat/allow-scripts": "^3.4.0",
"@metamask/auto-changelog": "^5.0.2",
"@metamask/create-release-branch": "^4.1.3",
"@metamask/eslint-config": "^14.0.0",
"@metamask/eslint-config": "^15.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Peer dependency mismatch with related eslint-config packages

Bumping @metamask/eslint-config to ^15.0.0 creates peer dependency conflicts. The companion packages (@metamask/eslint-config-browser, @metamask/eslint-config-jest, @metamask/eslint-config-nodejs, @metamask/eslint-config-typescript) remain at ^14.0.0, but they declare @metamask/eslint-config: ^14.0.0 as a peer dependency. According to the release notes, v15.0.0 versions of these companion packages exist specifically to update this peer dependency requirement. This mismatch will cause npm/yarn peer dependency warnings or errors and could lead to unexpected ESLint configuration behavior.

Fix in Cursor Fix in Web

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Peer dependency mismatch for eslint config related packages

Bumping @metamask/eslint-config to 15.0.0 creates a peer dependency mismatch. The related packages (@metamask/eslint-config-browser, @metamask/eslint-config-jest, @metamask/eslint-config-nodejs, @metamask/eslint-config-typescript) remain at 14.0.0 and have a peer dependency requiring @metamask/eslint-config@^14.0.0. According to the release notes, all these packages need to be bumped to 15.0.0 together since they updated their peer dependencies in that release.

Additional Locations (1)

Fix in Cursor Fix in Web

"@metamask/eslint-config-browser": "^14.0.0",
"@metamask/eslint-config-jest": "^14.0.0",
"@metamask/eslint-config-nodejs": "^14.0.0",
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3276,9 +3276,9 @@ __metadata:
languageName: node
linkType: hard

"@metamask/eslint-config@npm:^14.0.0":
version: 14.0.0
resolution: "@metamask/eslint-config@npm:14.0.0"
"@metamask/eslint-config@npm:^15.0.0":
version: 15.0.0
resolution: "@metamask/eslint-config@npm:15.0.0"
dependencies:
"@eslint/js": "npm:^9.11.0"
globals: "npm:^15.9.0"
Expand All @@ -3290,7 +3290,7 @@ __metadata:
eslint-plugin-prettier: ^5.2.1
eslint-plugin-promise: ^7.1.0
prettier: ^3.3.3
checksum: 10/b7ae38bf777e9341b8dfac75e98159fb5d5da7d913af2312b586c82370c84acff68ee78e3b104a3577a971d593c6039bd909c8d7ca41cb7a69ed069871080c8a
checksum: 10/93eb41bd61f3f4a0cf930a3d83e8893455f4f03339e91b21ef5a2835d24532db7c2916138a3e1b64777b5fb95cbe4ac90107697ac6f962c11ea7a99955cc75e4
languageName: node
linkType: hard

Expand Down Expand Up @@ -16487,7 +16487,7 @@ __metadata:
"@lavamoat/allow-scripts": "npm:^3.4.0"
"@metamask/auto-changelog": "npm:^5.0.2"
"@metamask/create-release-branch": "npm:^4.1.3"
"@metamask/eslint-config": "npm:^14.0.0"
"@metamask/eslint-config": "npm:^15.0.0"
"@metamask/eslint-config-browser": "npm:^14.0.0"
"@metamask/eslint-config-jest": "npm:^14.0.0"
"@metamask/eslint-config-nodejs": "npm:^14.0.0"
Expand Down
Loading