-
Notifications
You must be signed in to change notification settings - Fork 293
Fix incorrect codename of EPYC 7763v #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@codgician : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 3e4f5e5: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
|
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
|
#sign-off |
|
Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @mattmcinnes |
|
@codgician : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Hi @codgician - Thanks for your review. In the public repo, pull requests should be signed off by the author, another member of the content team, or a PM. @mattmcinnes Could you take a look? Thanks! |
|
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
|
Can you review this old PR and determine whether it needs to be closed or merged? @MicrosoftDocs/public-repo-pr-review-team |
|
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
|
I sent an email to the content owner today. @MicrosoftDocs/public-repo-pr-review-team |
|
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
|
I sent a Teams message to the author today. |
|
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
|
I sent an email to the content owner today. @MicrosoftDocs/public-repo-pr-review-team |
|
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
|
I sent email to the content owner today. @MicrosoftDocs/public-repo-pr-review-team |
|
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
|
I sent an email to the content owner today. @MicrosoftDocs/public-repo-pr-review-team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR corrects the codename for AMD EPYC 7763v processor from "Genoa" to "Milan" across multiple Azure VM specifications. The EPYC 7763v belongs to the 3rd generation AMD EPYC family, which uses the Milan codename, while Genoa is the codename for the 4th generation 9004 family.
- Corrects processor codename from Genoa to Milan for AMD EPYC 7763v
- Updates documentation consistency across different VM series specifications
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| articles/virtual-machines/sizes/storage-optimized/includes/lasv3-series-specs.md | Updates processor codename for Lasv3 series VMs |
| articles/virtual-machines/sizes/memory-optimized/includes/easv5-series-specs.md | Updates processor codename for Easv5 series VMs |
| articles/virtual-machines/sizes/general-purpose/includes/dasv4-series-specs.md | Updates processor codename for Dasv4 series VMs |
| articles/virtual-machines/sizes/general-purpose/includes/basv2-series-specs.md | Updates processor codename for Basv2 series VMs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
EPYC 7763v belongs to the 3rd generation of AMD EPYC family, whose codename should be Milan instead of Genoa. Genoa is the codename of 9004 family.