Skip to content

Fix: serialize allowed_signature_methods correctly as JSON array #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rh0mb wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix: serialize allowed_signature_methods correctly as JSON array #15

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5be5ff0
Fix: serialize allowed_signature_methods correctly as JSON array
rh0mb Jul 22, 2025
1420081
Fix: send allowed_signature_methods as array using [] syntax in multi…
rh0mb Jul 22, 2025
5d36fca
Fix: properly support multiple allowed_signature_methods per signer
rh0mb Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions mifiel/document.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,15 @@ def create(client, signatories, **kwargs):
data = kwargs.copy()
for index, item in enumerate(signatories):
for key, val in item.items():
data.update(
{'signatories[' + str(index) + '][' + str(key) + ']': val}
)
if key == 'allowed_signature_methods' and isinstance(val, list):
for method in val:
data.append(
(f'signatories[{index}][{key}][]', method)
)
else:
data.append(
(f'signatories[{index}][{key}]', val)
)

if 'viewers' in data:
viewers = data.pop('viewers')
Expand Down