[feat]Add metrics to prometheus-grafana dashboard and logs #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero0307
requested review from
harrisonyhq,
hek14,
mag1c-h,
qyh111 and
ygwpz
as code owners
hero0307
force-pushed
the
dev_metrics
branch
from
b4370e7 to
4f80c77
Compare
flesher0813
reviewed
Dec 10, 2025
| def build_kv_connector_stats( | ||
| cls, data: dict[str, Any] | None = None | ||
| ) -> Optional[KVConnectorStats]: | ||
| return UCMDirectConnector.build_kv_connector_stats(data) |
Contributor
There was a problem hiding this comment.
Must we use specific class here?
| self.data[worker_rank][metric_name] = [] | ||
| self.data[worker_rank][metric_name].extend(values) | ||
| else: | ||
| # Other is a different type, treat as single worker "0" |
Contributor
There was a problem hiding this comment.
Will there be other connector's stats aggregate with UCMKVConnectorStats?
|
|
||
| def observe( | ||
| self, | ||
| transfer_stats_data: dict[str, Any] | KVConnectorStats, |
Contributor
There was a problem hiding this comment.
Seen KVConnectorPromMetrics define this func like below, why we need to change the params?
flesher0813
reviewed
Dec 11, 2025
test/common/uc_eval/utils/metric.py
Outdated
| self, | ||
| expected_output: Union[str, List[str], tuple[str]], | ||
| real_output: str, | ||
| **kwargs |
Contributor
There was a problem hiding this comment.
No need to add this comma
| for worker_data in self.data.values() | ||
| ) | ||
|
|
||
| def aggregate(self, other: KVConnectorStats) -> KVConnectorStats: |
Contributor
There was a problem hiding this comment.
The excessive nesting depth (five levels) can be simplified by extracting helper functions and streamlining conditional checks. Same as function reduce
hero0307
force-pushed
the
dev_metrics
branch
from
5406e4d to
83741d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add the metrics display function to ucm_connector. You can specify which metrics to display on prometheus-grafana by configuring the metrics_configs.yaml file, and these metrics will also be output to the logs.
Modifications
Add three interfaces get_kv_connector_stats, build_kv_connector_stats and build_prom_metrics, as well as two classes UCMKVConnectorStats and UCMPromMetrics to ucm_connector.
Test
prometheus-grafana display
log display