Migrate nav bar to Astro #4
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iLynxcat
requested changes
May 10, 2025
Collaborator
iLynxcat
left a comment
iLynxcat
left a comment
There was a problem hiding this comment.
Great start, but let's try to start cleaning things up a little bit & take advantage of Astro's CSS scoping & JS loading
Comment on lines
41
to
43
| <a href="/play" class="play-button-container" | ||
| ><button id="join-now-button" class="desktop-only play-now-button">Play Now!</button></a | ||
| > |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
|
Can we move the Play Now! button over to the right? 
|
iLynxcat
force-pushed
the
refactor/astro-avbar
branch
from
859566e to
e582379
Compare
iLynxcat
reviewed
May 13, 2025
Collaborator
iLynxcat
left a comment
iLynxcat
left a comment
There was a problem hiding this comment.
Nice work getting the right side moved over properly!
| margin-bottom: -8px !important; | ||
| height: 67px !important; | ||
| margin-top: -12px !important; | ||
| margin-bottom: -12px !important; |
Collaborator
There was a problem hiding this comment.
What's not cascading properly that we need to use !important here?
src/components/NavBar.astro
Outdated
Comment on lines
201
to
195
| max-height: 66px; | ||
| max-height: 66.5px; |
Collaborator
There was a problem hiding this comment.
What did the sizing look like before/after here? Just curious the difference
Author
There was a problem hiding this comment.
The image was slightly smaller and if i went up a full pixel it would be bigger .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.