Skip to content

Conversation

@tyler-lutz
Copy link

No description provided.

@AristurtleDev
Copy link
Contributor

@tyler-lutz There's no description in the PR or the commit and github doesn't provide any diff at the file execution flag level.

What did you do to set these as executable? Was it just a chmod +x or did you use git update-index?

@tyler-lutz
Copy link
Author

I just used chmod +x

@harry-cpp
Copy link
Member

@AristurtleDev you can see in the files changed section the mode modification:
Screenshot 2025-11-11 at 19 39 32

644 -> 755 means he added executable bit for each category to the file, each one of those numbers represents a category (owner, group, others), and each number uses 3 bits for read(1 << 2), write(1 << 1) and execute(1 << 0).

@AristurtleDev
Copy link
Contributor

@AristurtleDev you can see in the files changed section the mode modification: Screenshot 2025-11-11 at 19 39 32

644 -> 755 means he added executable bit for each category to the file, each one of those numbers represents a category (owner, group, others), and each number uses 3 bits for read(1 << 2), write(1 << 1) and execute(1 << 0).

I was asking because I had an issue in another repository where changing them with just chmod +x didn't resolve it fully. It had to be changed with git update-index as well

@tyler-lutz
Copy link
Author

@AristurtleDev Is core.filemode set to false in your git config. If it is that would be why you had to use git update-index instead of just using chmod +x

The mode changes here are correct so they should be good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants