-
Notifications
You must be signed in to change notification settings - Fork 38
Add protonation modification ASPprot, GLUprot, HISprot1 and HISprot2 … #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…in mon_lib_list.cif
|
Did you do any test (hydrogen generation, refinement etc) using this? Please update links_and_mods.cif as well, by doing See #49 for details. |
…in links_and_mods.cif
keitaroyam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think modifications should be minimum. Please see specific comments.
(Changes should be made in list/mon_lib_list.cif and then copied to links_and_mods.cif)
links_and_mods.cif
Outdated
| ASPprot change CA CB CG OD1 chi2 180.000 20.0 6 | ||
| ASPprot change O C CA N sp2_sp3_1 0.000 20.0 6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are irrelevant and may be removed.
links_and_mods.cif
Outdated
| GLUprot change CB CG CD OE1 chi3 180.000 20.0 6 | ||
| GLUprot change O C CA N sp2_sp3_1 0.000 20.0 6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are unnecessary
links_and_mods.cif
Outdated
| loop_ | ||
| _chem_mod_tor.mod_id | ||
| _chem_mod_tor.function | ||
| _chem_mod_tor.atom_id_1 | ||
| _chem_mod_tor.atom_id_2 | ||
| _chem_mod_tor.atom_id_3 | ||
| _chem_mod_tor.atom_id_4 | ||
| _chem_mod_tor.id | ||
| _chem_mod_tor.new_value_angle | ||
| _chem_mod_tor.new_value_angle_esd | ||
| _chem_mod_tor.new_period | ||
| HISprot1 change CA CB CG CD2 chi2 90.000 20.0 6 | ||
| HISprot1 change O C CA N sp2_sp3_1 0.000 20.0 6 | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unnecessary changes
links_and_mods.cif
Outdated
| loop_ | ||
| _chem_mod_tor.mod_id | ||
| _chem_mod_tor.function | ||
| _chem_mod_tor.atom_id_1 | ||
| _chem_mod_tor.atom_id_2 | ||
| _chem_mod_tor.atom_id_3 | ||
| _chem_mod_tor.atom_id_4 | ||
| _chem_mod_tor.id | ||
| _chem_mod_tor.new_value_angle | ||
| _chem_mod_tor.new_value_angle_esd | ||
| _chem_mod_tor.new_period | ||
| HISprot2 change CA CB CG CD2 chi2 90.000 20.0 6 | ||
| HISprot2 change O C CA N sp2_sp3_1 0.000 20.0 6 | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unnecessary changes
|
Has anybody tested this? |
|
I did for neutron.
…Sent from my iPhone
On 11 Feb 2025, at 15:04, GaribMurshudov ***@***.***> wrote:
Has anybody tested this?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
|
Have we addressed concerns raised by Keitaro? I guess @flong-mrc might need to look into this |
|
OK, I manually removed the unnecessary torsion angle changes. We can merge this if you are happy with it. Acedrg may be updated later. |
GaribMurshudov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope these were tested.
…in
mon_lib_list.cif