Skip to content

Conversation

@LucreziaCatapano
Copy link
Contributor

…in mon_lib_list.cif

@keitaroyam
Copy link
Contributor

Did you do any test (hydrogen generation, refinement etc) using this?

Please update links_and_mods.cif as well, by doing

sed -n '/^data_link_list/,$p' list/mon_lib_list.cif > links_and_mods.cif

See #49 for details.

Copy link
Contributor

@keitaroyam keitaroyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think modifications should be minimum. Please see specific comments.
(Changes should be made in list/mon_lib_list.cif and then copied to links_and_mods.cif)

Comment on lines 12318 to 12319
ASPprot change CA CB CG OD1 chi2 180.000 20.0 6
ASPprot change O C CA N sp2_sp3_1 0.000 20.0 6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are irrelevant and may be removed.

Comment on lines 12372 to 12373
GLUprot change CB CG CD OE1 chi3 180.000 20.0 6
GLUprot change O C CA N sp2_sp3_1 0.000 20.0 6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are unnecessary

Comment on lines 12432 to 12445
loop_
_chem_mod_tor.mod_id
_chem_mod_tor.function
_chem_mod_tor.atom_id_1
_chem_mod_tor.atom_id_2
_chem_mod_tor.atom_id_3
_chem_mod_tor.atom_id_4
_chem_mod_tor.id
_chem_mod_tor.new_value_angle
_chem_mod_tor.new_value_angle_esd
_chem_mod_tor.new_period
HISprot1 change CA CB CG CD2 chi2 90.000 20.0 6
HISprot1 change O C CA N sp2_sp3_1 0.000 20.0 6

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary changes

Comment on lines 12533 to 12546
loop_
_chem_mod_tor.mod_id
_chem_mod_tor.function
_chem_mod_tor.atom_id_1
_chem_mod_tor.atom_id_2
_chem_mod_tor.atom_id_3
_chem_mod_tor.atom_id_4
_chem_mod_tor.id
_chem_mod_tor.new_value_angle
_chem_mod_tor.new_value_angle_esd
_chem_mod_tor.new_period
HISprot2 change CA CB CG CD2 chi2 90.000 20.0 6
HISprot2 change O C CA N sp2_sp3_1 0.000 20.0 6

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary changes

@GaribMurshudov
Copy link
Contributor

Has anybody tested this?

@LucreziaCatapano
Copy link
Contributor Author

LucreziaCatapano commented Feb 11, 2025 via email

@GaribMurshudov
Copy link
Contributor

Have we addressed concerns raised by Keitaro? I guess @flong-mrc might need to look into this

@keitaroyam
Copy link
Contributor

OK, I manually removed the unnecessary torsion angle changes. We can merge this if you are happy with it. Acedrg may be updated later.

Copy link
Contributor

@GaribMurshudov GaribMurshudov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope these were tested.

@keitaroyam keitaroyam merged commit d12ceca into MonomerLibrary:master Feb 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants