-
Notifications
You must be signed in to change notification settings - Fork 1
Applies changes from rtCamp #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rtCamp provided: 1. Gutenberg support, provided by the JS files in the `block` directory 2. Unit testing of the plugin with `phpunit` 3. Updates to the Docker configuration 4. Updates to the README
|
Few issues:
|
There's a "Classic Editor" block available in the Gutenberg editor that simulates the Classic Editor. You can also download the plugin as a I'll update test steps with these details.
In my testing the embed is rendered as an "embed" block a few seconds after pasting in the URL. Can you check your console for any potential errors here?
This is expected, as the DocumentCloud block parses the URL for the ID, but our oEmbed endpoint doesn't handle it as well: MuckRock/documentcloud#308 |
|
No errors in the console. This is what I see in both Chrome and Firefox. It loads a line. When I open to view it in a preview, the embed works. |
|
@duckduckgrayduck I think the issue you're encountering is MuckRock/documentcloud#301. If you inspect the "line", it should be a 0 height iframe. |
|
@allanlasser that is correct. The calculated height is the issue. Not an unknown issue. |



These changes update the DocumentCloud Wordpress to version
0.6.0:[documentcloud]shortcode in the Classic Editor.To Test
README.mdREADME.md