Create separate sample_data_type records for different sections #531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
docsis updateddocs/changelog.mdis updatedDescription of changes
SampleDataTypealready exists. However it only checks on the basis ofdata_id, but ignoresdata_section. Therefore if multiple report types (data sections) reuse the samedata_id, currently this will reuse thatSampleDataTypeeven ifdata_sectionis wrong for the incoming report.SampleDataTypeentries based ondata_key, which includes bothdata_idanddata_section.