forked from key4hep/k4ActsTracking
-
Notifications
You must be signed in to change notification settings - Fork 2
Add unit test suite for k4ActsTracking core components #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
39
commits into
main
Choose a base branch
from
copilot/add-test-suite-k4acts-tracking
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's weird that this didn't pull with the rest of the changes ...
Necessary due to acts-project/acts#3975
This only makes things build with v32 and v43, there are certainly versions in between where different changes would be necessary. (Potentially incomplete) list of related ACTS PRs: - acts-project/acts#3337 - acts-project/acts#4005
Fix Geo Mapping
Removed ROOT, EDM4hep, and Gaudi from the list of acts.
- Modified ACTSAlgBase to update geometry configuration - Added buildsub/, installsub/, and setup.sh to gitignore
Update to TGeoDescFile JSONs
Co-authored-by: madbaron <7315158+madbaron@users.noreply.github.com>
… documentation Co-authored-by: madbaron <7315158+madbaron@users.noreply.github.com>
…or Gaudi interface spelling Co-authored-by: madbaron <7315158+madbaron@users.noreply.github.com>
…e raw pointers with smart pointers Co-authored-by: madbaron <7315158+madbaron@users.noreply.github.com>
Co-authored-by: madbaron <7315158+madbaron@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement test suite for k4ActsTracking package
Add unit test suite for k4ActsTracking core components
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Point 1 (Unit Tests) from the test suite proposal: establish Google Test infrastructure and validate ActsGaudiLogger, helper functions, and geometry context operations.
Changes
Test Infrastructure
test/unit/CMakeLists.txt)TestMocks.h: MockMessageSvc for IMessageSvc interface testingTests Implemented
ActsGaudiLogger (11 tests, ~80% coverage)
Helper Functions (14 tests)
Geometry Context (10 tests)
Documentation
test/README.md(246 lines): Test structure, coverage summary, running instructionstest/unit/TESTING.md(329 lines): Test patterns, mock usage, debugging guide, coverage goalsExample Usage
Metrics
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.