3D Hierarchy support :) #93
Merged
+310
−163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Umberto Zerbinati <zerbinati@maths.ox.ac.uk>
connorjward
requested changes
Oct 23, 2025
| nodes_to_correct_sorted.sort() | ||
| nodes_to_correct_index = np.unique(nodes_to_correct_sorted) | ||
| tic = time.time() | ||
| logger.info("\t\t\tSanpping the DMPlex to NETGEN mesh") |
Collaborator
There was a problem hiding this comment.
Suggested change
| logger.info("\t\t\tSanpping the DMPlex to NETGEN mesh") | |
| logger.info("\t\t\tSnapping the DMPlex to NETGEN mesh") |
| petscPlexCoordinates.setArray(petscCoordinates.reshape((-1,1))) | ||
| petscPlex.setCoordinatesLocal(petscPlexCoordinates) | ||
| toc = time.time() | ||
| logger.debug(f"\t\t\tSanp the DMPlex to NETGEN mesh. Time taken: {toc - tic} seconds") |
Collaborator
There was a problem hiding this comment.
Suggested change
| logger.debug(f"\t\t\tSanp the DMPlex to NETGEN mesh. Time taken: {toc - tic} seconds") | |
| logger.debug(f"\t\t\tSnap the DMPlex to NETGEN mesh. Time taken: {toc - tic} seconds") |
| :arg mesh: the Netgen/NGSolve mesh | ||
| :arg levs: the number of levels in the hierarchy | ||
| :arg netgen_flags: either a bool or a dictionray containing options for Netgen. | ||
| :arg flags: either a bool or a dictionray containing options for Netgen. |
Collaborator
There was a problem hiding this comment.
Suggested change
| :arg flags: either a bool or a dictionray containing options for Netgen. | |
| :arg flags: either a bool or a dictionary containing options for Netgen. |
pbrubeck
reviewed
Oct 27, 2025
Comment on lines
+62
to
+64
| A[0,0] = (coordinates[cell[1]]-coordinates[cell[0]])[0] | ||
| A[0,1] = (coordinates[cell[1]]-coordinates[cell[0]])[1] | ||
| A[0,2] = (coordinates[cell[1]]-coordinates[cell[0]])[2] |
Collaborator
There was a problem hiding this comment.
Suggested change
| A[0,0] = (coordinates[cell[1]]-coordinates[cell[0]])[0] | |
| A[0,1] = (coordinates[cell[1]]-coordinates[cell[0]])[1] | |
| A[0,2] = (coordinates[cell[1]]-coordinates[cell[0]])[2] | |
| A[0,:] = coordinates[cell[1]] - coordinates[cell[0]] |
Collaborator
There was a problem hiding this comment.
Or even better
for i in range(3):
A[i, :] = coordinates[cell[i+1]] - coordinates[cell[i]]
pbrubeck
reviewed
Oct 27, 2025
| if np.linalg.det(A) > 0: | ||
| cells[i] = cell | ||
| else: | ||
| cells[i] = np.array([cell[0],cell[1],cell[2], cell[2]]) |
Collaborator
There was a problem hiding this comment.
Aren't cell[i] the vertices?
pbrubeck
reviewed
Oct 27, 2025
Comment on lines
+80
to
+81
| cStart = start_end[0] | ||
| cEnd = start_end[1] |
Collaborator
There was a problem hiding this comment.
Style
Suggested change
| cStart = start_end[0] | |
| cEnd = start_end[1] | |
| cStart, cEnd = start_end |
pbrubeck
reviewed
Oct 27, 2025
Comment on lines
+101
to
+102
| cStart = start_end[0] | ||
| cEnd = start_end[1] |
Collaborator
There was a problem hiding this comment.
Suggested change
| cStart = start_end[0] | |
| cEnd = start_end[1] | |
| cStart, cEnd = start_end |
pbrubeck
reviewed
Oct 27, 2025
| if np.linalg.det(A) > 0: | ||
| cells[i] = cell | ||
| else: | ||
| cells[i] = np.array([cell[0],cell[1],cell[2], cell[2]]) |
Collaborator
There was a problem hiding this comment.
Suggested change
| cells[i] = np.array([cell[0],cell[1],cell[2], cell[2]]) | |
| cells[i] = np.array([cell[0], cell[1], cell[3], cell[2]]) |
pbrubeck
reviewed
Oct 27, 2025
| for i in range(cStart,cEnd): | ||
| sIndex = sIndicies[i] | ||
| if len(sIndex)==4: | ||
| cell = list(set(cell_indicies[i])) |
Collaborator
There was a problem hiding this comment.
Choosing a better name can help clarifying the logic here
Suggested change
| cell = list(set(cell_indicies[i])) | |
| cell_verts = list(set(cell_indicies[i])) |
pbrubeck
reviewed
Oct 27, 2025
Comment on lines
+54
to
+55
| cStart = start_end[0] | ||
| cEnd = start_end[1] |
Collaborator
There was a problem hiding this comment.
Suggested change
| cStart = start_end[0] | |
| cEnd = start_end[1] | |
| cStart, cEnd = start_end |
pbrubeck
reviewed
Oct 27, 2025
| for i in range(cStart,cEnd): | ||
| sIndex = sIndicies[i] | ||
| if len(sIndex)==4: | ||
| cell = list(set(cell_indicies[i])) |
Collaborator
There was a problem hiding this comment.
What is the role of casting into a set? Are we ever going to get repeated vertices or do we only want to sort the vertices?
Collaborator
Author
There was a problem hiding this comment.
Remove duplicates
added 2 commits
December 16, 2025 19:18
added 2 commits
December 16, 2025 19:26
Signed-off-by: uzerbianati <zerbinati@maths.ox.ac.uk>
Signed-off-by: uzerbianati <zerbinati@maths.ox.ac.uk>
This was referenced Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.