-
Notifications
You must be signed in to change notification settings - Fork 0
Script that modifies MATRIX y_ttbar grids
#98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The pre-commit complains? |
| pass | ||
|
|
||
|
|
||
| class TestReverseBins: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't add it here - regardless if it will (already) become a proper pinefarm module or no. This lives just as well in the place where it belongs: tests/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving the tests part into tests/ is indeed a good idea regardless. Right now I don't have any time at all but will do so as soon as I have some.
| required=True, | ||
| help="Name of the output Grid (w/o the extension `pineappl.lz4`).", | ||
| ) | ||
| def main(grid_path: str, output_name: str) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to test the CLI as well? since there are a series of commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that'd be added along with an additional test for modify_grids.
|
Hi @Radonirinaunimi, this works great! One comment, while using this script I noticed that the normalisation given by
gives and as you can see |
In order to perform fewer runs with MATRIX, predictions for$\pm y_{t \bar{t}}$ can be extracted from $|y_{t \bar{t}}|$ . The following script does so by performing the following operations:
TODO:
pinefarmmodule (?) - deprecates 3rd point