Skip to content

Conversation

@JanghyunJK
Copy link
Contributor

@JanghyunJK JanghyunJK commented Apr 21, 2025

Pull request overview

  • converting Coil:_:DX:MultiSpeed to Coil:_:DX:VariableSpeed object for advanced heat pump RTU modeling
  • based on how I'm understanding, we had multiple performance issues with multi-spd coil object
  • one of them that I saw from upsizing simulations was that electric backup wasn't kicking in when it was supposed to
  • Edwin, I believe, mentioned var-spd coil obj is more reliable so I'm trying the var-spd for the HPRTU measure
  • while testing the conversion, I also found a typo in the comstock sensitivity measure. so fixing that too.

Pull Request Author

This pull request makes changes to (select all the apply):

  • Documentation
  • Infrastructure (includes apptainer image, buildstock batch, dependencies, continuous integration tests)
  • Sampling
  • Workflow Measures
  • Upgrade Measures
  • Reporting Measures
  • Postprocessing

Author pull request checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • Added tests for new measures
  • Updated measure .xml(s)
  • Register values added to comstock_column_definitions.csv
  • Both options_lookup.tsv files updated
  • 10k+ test run
  • Change documentation written
  • Measure documentation written
  • ComStock documentation updated
  • Changes reflected in example .yml files
  • Changes reflected in README.md files
  • Added 'See ComStock License' language to first two lines of each code file
  • Implements corresponding measure tests and indexing path in test/reporting_measure_tests.txt, test/workflow_measure_tests.txt, or test/upgrade_measure_tests.txt
  • All new and existing tests pass the CI

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: data and method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • Reviewed change documentation
  • Ensured code files contain License reference
  • Results differences are reasonable
  • Make sure the newly added measures has been added with tests and indexed properly
  • CI status: all tests pass

@JanghyunJK JanghyunJK added the upgrade measure PR improves or adds upgrade measures label Apr 21, 2025
Base automatically changed from jk/hprtu-window-roof-upsizing to ccaradon/sdr_2025_r2 April 23, 2025 15:06
@JanghyunJK JanghyunJK changed the title [WIP] SDR: HPRTU multi-spd obj to var-spd obj coil conversion SDR: HPRTU multi-spd obj to var-spd obj coil conversion Jul 30, 2025
@JanghyunJK JanghyunJK changed the base branch from ccaradon/sdr_2025_r2 to ccaradon/sdr_2025_r4 September 9, 2025 16:04
@JanghyunJK JanghyunJK force-pushed the multi-to-var-spd-coil-conversion branch from a5d7413 to 777b159 Compare September 9, 2025 17:03
@axelstudios axelstudios force-pushed the ccaradon/sdr_2025_r4 branch 2 times, most recently from 7cf2a5c to 27f45bc Compare November 19, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

upgrade measure PR improves or adds upgrade measures

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants