Skip to content

Conversation

@JanghyunJK
Copy link
Contributor

@JanghyunJK JanghyunJK commented May 20, 2025

Pull request overview

  • putting this before I forget
  • noticed our HPRTU model might have coil rated flow with value A while variable fan max flow with value B (i.e., so not matching)
  • this might threw many errors during simulation such like this below:
** Warning ** GetDXCoils: Coil:Heating:DX:MultiSpeed="ZONE SMALLHOTEL STAIR A  - STORY GROUND PSZ-AC HEAT PUMP COIL" curve values
   **   ~~~   ** ... Defrost Energy Input Ratio Function of Temperature Curve Name = ZONE SMALLHOTEL STAIR A  - STORY GROUND PSZ-AC DEFROST_EIR output is not equal to 1.0 (+ or - 10%) at rated conditions.
   **   ~~~   ** ... Curve output at rated conditions = 0.152
   ** Severe  ** AirLoopHVAC:UnitarySystem = ZONE SMALLHOTEL STAIR A  - STORY GROUND RTU SZ-VAV HEAT PUMP
   **   ~~~   ** ... air flow rate = 1.2720342E-002 in fan object ZONE SMALLHOTEL STAIR A  - STORY GROUND PSZ-AC VFD FAN is less than the maximum HVAC system air flow rate in cooling mode.
   **   ~~~   **  The Cooling Supply Air Flow Rate is reset to the fan flow rate and the simulation continues.
   ** Severe  ** AirLoopHVAC:UnitarySystem = ZONE SMALLHOTEL STAIR A  - STORY GROUND RTU SZ-VAV HEAT PUMP
   **   ~~~   ** ... air flow rate = 1.2720342E-002 in fan object ZONE SMALLHOTEL STAIR A  - STORY GROUND PSZ-AC VFD FAN is less than the maximum HVAC system air flow rate in heating mode.
   **   ~~~   **  The Heating Supply Air Flow Rate is reset to the fan flow rate and the simulation continues.
  • So this PR is trying to match fan max flow with coil rated flow
  • Also, added an unit test to check that
  • We can change the base branch to something else later

@ChristopherCaradonna targeting this to be reflected in the next release

Pull Request Author

This pull request makes changes to (select all the apply):

  • Documentation
  • Infrastructure (includes apptainer image, buildstock batch, dependencies, continuous integration tests)
  • Sampling
  • Workflow Measures
  • Upgrade Measures
  • Reporting Measures
  • Postprocessing

Author pull request checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • Added tests for new measures
  • Updated measure .xml(s)
  • Register values added to comstock_column_definitions.csv
  • Both options_lookup.tsv files updated
  • 10k+ test run
  • Change documentation written
  • Measure documentation written
  • ComStock documentation updated
  • Changes reflected in example .yml files
  • Changes reflected in README.md files
  • Added 'See ComStock License' language to first two lines of each code file
  • Implements corresponding measure tests and indexing path in test/reporting_measure_tests.txt, test/workflow_measure_tests.txt, or test/upgrade_measure_tests.txt
  • All new and existing tests pass the CI

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: data and method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • Reviewed change documentation
  • Ensured code files contain License reference
  • Results differences are reasonable
  • Make sure the newly added measures has been added with tests and indexed properly
  • CI status: all tests pass

@JanghyunJK JanghyunJK added upgrade measure PR improves or adds upgrade measures bug Something isn't working labels May 20, 2025
@JanghyunJK JanghyunJK changed the title HPRTU measure: setting fan max flow the same as coil rated flow SDR: HPRTU measure: setting fan max flow the same as coil rated flow Jul 30, 2025
@JanghyunJK JanghyunJK changed the base branch from ccaradon/sdr_2025_r2 to ccaradon/sdr_2025_r4 September 9, 2025 16:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses an issue where HPRTU models had mismatched airflow rates between the coil rated flow and variable fan maximum flow, causing simulation errors. The fix ensures these values are properly aligned to prevent EnergyPlus warnings and errors.

  • Sets fan maximum flow rate to match the highest stage flow rate from cooling or heating
  • Adds unit test to verify airflow rates are consistent between fan and unitary system components
  • Includes code style improvements and cleanup in test files

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
measure.rb Added logic to set fan maximum flow rate to match the highest stage flow rate
measure_test.rb Added unit test to verify airflow consistency and various code style improvements
measure.xml Updated version ID and checksums to reflect code changes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@axelstudios axelstudios force-pushed the ccaradon/sdr_2025_r4 branch 2 times, most recently from 7cf2a5c to 27f45bc Compare November 19, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working upgrade measure PR improves or adds upgrade measures

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants