Skip to content

Conversation

@joseph-robertson
Copy link
Collaborator

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@joseph-robertson joseph-robertson added Enhancement Request component - HVAC Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. IDDChange labels Jan 14, 2025
@joseph-robertson joseph-robertson self-assigned this Jan 14, 2025
@joseph-robertson
Copy link
Collaborator Author

AirLoopHVAC:ExhaustSystem is like AirTerminal:SingleDuct:SeriesPIU:Reheat:

  • Zone Mixer Name
  • Fan Name

ZoneHVAC:ExhaustControl is like ZoneHVAC:LowTemperatureRadiant:VariableFlow or ZoneHVAC:IdealLoadsAirSystem?

Update ZoneHVACComponent with airLoopHVACExhaustSystem()? Or should AirLoopHVAC:ExhaustSystem have something like exhaust_system.zoneHVACExhaustControls()?

@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Jan 31, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component - HVAC component - Model Enhancement Request IDDChange Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E+ 22.1.0: Wrap ZoneHVAC:ExhaustControl

4 participants