Fix addToNode resetting plant loop fluid type

[joseph-robertson]

Pull request overview

• Fixes GroundHeatExchangerVertical_Impl::addToNode sets plant loop fluid type to Water #5458

Pull Request Author

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[jmarrec]

Okay I guess.

[jmarrec]

Why the switch from plant->supplyComponent to !plant->demandComponent?

What happens if you call it with a supply node on plantloop that's another model? It's NOT a demandComponent, so addToNode is called, when you could have avoided doing it?

[jmarrec]

I think BoilerSteam is the weird case here FYI, and ultimately, we should refuse to add it with a warning if done on a PlantLoop that's water/glycol and not steam. But probably do that in #5455

[joseph-robertson]

I was just following the addToNode method for GroundHeatExchangerHorizontalTrench. Sounds like this PR should just change addToNode for GroundHeatExchangerVertical, and leave BoilerHotWater/BoilerSteam alone.

[joseph-robertson]

ecba60c

[jmarrec]

Curious whether you can use Glycol ones with a BoilerHotWater or not in E+. Have you tried?

[joseph-robertson]

I have not tried.

[ci-commercialbuildings]

CI Results for 60b9d60:

• Ubuntu 24.04:

• Ubuntu 22.04:

• Darwin:

• Windows:

  • OpenStudio-3.10.1-alpha+60b9d60a70-Windows.exe
  • OpenStudio-3.10.1-alpha+60b9d60a70-Windows.tar.gz

• Code Coverage:

[jmarrec]

I guess now this is just for GroundHeatExchangerVertical now that boilers have been reverted, and I'm ok with it. Not sure whether that fixes ALL of the original issue or not, but I want to reduce the number of open PRs so let's drop it.