-
Notifications
You must be signed in to change notification settings - Fork 7
Map time resolution #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lixiliu
wants to merge
11
commits into
main
Choose a base branch
from
ll/aggregation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
- Coverage 91.24% 91.15% -0.10%
==========================================
Files 44 44
Lines 3335 3549 +214
==========================================
+ Hits 3043 3235 +192
- Misses 292 314 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
daniel-thom
reviewed
Mar 13, 2025
daniel-thom
reviewed
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #30
Mapping time resolution is defined by the time resolution in time_config as well as the optional param
resampling_operationinto the mapper function.Aggregation types:

Disaggregation types:

Interpolation mapping from hourly to 20-min:

A note on NA values in interpolation:
If one of the two row values used in the interpolation is NA, duckdb seems to treat that NA value as 0 and the interpolated value is non NA.
If both values are NA, then the result is NA.