feat: Adding autodetect for CSV files. #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
- Coverage 91.45% 91.36% -0.09%
==========================================
Files 44 46 +2
Lines 3464 3556 +92
==========================================
+ Hits 3168 3249 +81
- Misses 296 307 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
daniel-thom
reviewed
Oct 20, 2025
| dict | ||
| File information including columns, detected format, size, and recommendations | ||
| """ | ||
| import duckdb |
Collaborator
There was a problem hiding this comment.
This function could reside in csv_io.py. It doesn't need self, right?
| def _get_file_size(path: str | Path) -> int: | ||
| try: | ||
| return os.path.getsize(path) | ||
| except (OSError, FileNotFoundError): |
Collaborator
There was a problem hiding this comment.
Shouldn't you return an error if the file doesn't exist?
|
|
||
|
|
||
| @lru_cache(maxsize=32) | ||
| def _get_file_size(path: str | Path) -> int: |
Collaborator
There was a problem hiding this comment.
Is this needed? Wouldn't it be risky? It seems like someone could change the file during a session.
| """ | ||
| return self.ingest_from_csvs((path,), src_schema, dst_schema, connection=connection) | ||
| if _should_use_auto_detect(auto_detect) and _is_large_file(path): | ||
| logger.info(f"Processing large file {path} with auto-detection optimizations") |
Collaborator
There was a problem hiding this comment.
What is the optimization?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.