nvidia-uvm: Add support for kernel 6.18 get_dev_pagemap API change #951
+23
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The get_dev_pagemap() function signature changed in Linux kernel 6.18 to take only a single pfn parameter, removing the lock parameter. This commit adds a conftest check to detect the API version and conditionally calls get_dev_pagemap() with the appropriate number of arguments.
Collaborator
|
Thanks for pull request. We have an equivalent change that will be included in an upcoming release. |
Author
|
Aww ok :( |
Yeah. I feel your pain. Nvidia almost never merge public PRs. this repo is like their public commit squash dump. It's only open as you can see it but good luck getting changes upstreamed. |
Yeah, can we have the official version? Usually, we also need to update the other old drivers with similar fixes. |
|
I just checked that nvidia-470xx does not need any backport to build with kernel 6.18.0-0.rc5, but when it does, we prefer to use a solution inspired by the code here. It is relatively easy to adapt to older drivers. Best regards |
3 tasks
|
@aritger Any progress on the official 6.18 support? It's almost 1 1/2+ months since this PR and I really want something official to pair with intel granite rapids cpu as the intel cpu requires 6.18 for optimal scheduling. Right now all the official releases are only compat up to 6.14. |
590 does support it and does not require any patches. The last 580 release is also compatible with 6.17 btw |
|
I tried (not from this repo) but just instaling nvidia-580-open (580.105.08) from nvidia repo on Ubuntu main (6.17.11-061711-generic) kernel and it failed dkms compile for ubuntu 24.04. I assme nvidia-dkms-open-580.105.08 is same as the tagged code from this repo: Considering Nvidia considers Ubuntu 24.04 official supported distro, this is frustating. I have no clue why there appears to be gcc ompiler compat errors as it if the open kernel on latest kernels expect something version of gcc not available on 24.04 |
Oh, thats sad. Yes, if need to be utilized NVIDIA's official repo then this is a blocker. |
|
@ptr1337 But the good new is cuda driver 590-open is comptbile with 6.17 and 6.18. dkms compile worked. I just think their 580 released |
I think generally on ubuntu you could also use their included installer in the .run file :) But I do not know how good it is and the files are not tracked by the package manager. Also, take a look here: |
I am not going to touch binary cli installers unless I am totally out of options. =)
Thanks. It really helped. Btw, |
Member
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The get_dev_pagemap() function signature changed in Linux kernel 6.18 to take only a single pfn parameter, removing the lock parameter.
This commit adds a conftest check to detect the API version and conditionally calls get_dev_pagemap() with the appropriate number of arguments.