feat: file-backed cache for heatmap #62
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some use cases, avoiding parsing perf data for multiple times contributes the flamescope server performance & its users' experience. flamescope already has an in-memory cache for the analyzed perf data, and this PR adds file-backed one in case of in-memory cache miss.
In our case, we render some graphs in a page by querying to flamescope which we run with three or a few more instances and the most simplest way to share processed data between them is file-backed cache.
To enable this feature, change
USE_HEATMAP_FILECACHEin app/config.py toTrue.Related issue: #58