Add the option to set the client name #157
Conversation
Fogapod
left a comment
Fogapod
left a comment
There was a problem hiding this comment.
Is there a way to add a test for this?
aredis/connection.py
Outdated
| if nativestr(await self.read_response()) != 'OK': | ||
| raise ConnectionError('Invalid Database') | ||
|
|
||
| if self.client_name: |
There was a problem hiding this comment.
| if self.client_name: | |
| if self.client_name is not None: |
aredis/connection.py
Outdated
| parser_class=DefaultParser, reader_read_size=65535, | ||
| encoding='utf-8', decode_responses=False, | ||
| *, loop=None): | ||
| *, loop=None, client_name=None): |
There was a problem hiding this comment.
IMO client_name should be defined before loop as it is application configuration unlike loop, but this is very subjective.
Added by setting the client_name on the connection in the tests. Also rebased on master. |
|
@Fogapod Any chance of reviewing this again? |
|
@dovreshef yeah, looks good now, but I'm not a maintainer. I just left 2 comments |
|
I see. Thanks. @NoneGG Can this be merged? Reviewed? |
|
Hi @dovreshef -- just wanted to let you know that my org has recently forked Also wanted to thank you for implementing the redis v5 username & password support, as that made some of my testing a bit easier :) |
Derived from NoneGG/aredis#157
Derived from NoneGG/aredis#157
4 participants
No description provided.