Rewrite Blue LED segment for VapeDetect #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philip-larose
suggested changes
Apr 11, 2021
Contributor
philip-larose
left a comment
philip-larose
left a comment
There was a problem hiding this comment.
I'd change the last sentence of Blue to "In this mode, the device sends a VapeDetect alert to the system with the abnormal sensor data results." Presuming that's correct, that it does send information on what the device detected that set off the sensors; alternately, just "In this mode, the device sends a VapeDetect alert to the system."
Contributor
Author
|
In this case, blue is just an indicator that something is weird, not that it is sending any extra data to the sensor. When it goes Green, that means that vape was detected and it sending an alert to the service. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.