[18.0] [IMP] agreement: allow to select hierarchy contacts #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @alexis-via, @ygol, |
Contributor
|
LGTM |
Contributor
Author
|
CI is red, but unrelated to this PR. |
Contributor
Author
|
CI is fixed with this PR, that should be merged first: |
By shifting the constraint to the commercial entity, computed from the partner field, we can now select hierarchy contacts. This is useful to: A) Register the contact person of the agreement B) Support modules like `partner_affiliate`, in case of nested businesses
ivantodorovich
force-pushed
the
18.0-imp-agreement-commercial-partner
branch
from
03e2ad6 to
7506bd4
Compare
Contributor
Author
|
rebased and all's green |
vvrossem
approved these changes
Sep 22, 2025
|
/ocabot rebase |
Contributor
|
@leemannd The rebase process failed, because command |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By shifting the constraint to the commercial entity, computed from the partner field, we can now select hierarchy contacts.
This is useful to:
A) Register the contact person of the agreement
B) Support modules like
partner_affiliate, in case of nested businesses