-
-
Notifications
You must be signed in to change notification settings - Fork 456
[18.0][ADD] marketing_crm_calendar: copy campaign fields from phonecalls to calendar events #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
[18.0][ADD] marketing_crm_calendar: copy campaign fields from phonecalls to calendar events #664
Conversation
b2766bd to
11b1bf7
Compare
HaraldPanten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Module name needs to be improved
javierizaca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @BetoRaja
The foundation of the approach works correctly, although I think it would be desirable—so as to improve the user experience—to modify the following:
- The order of the fields in the events’ form view: Campaign > Source > Medium. This follows the standard that Odoo uses for other models, since it is the way to hierarchize data in Marketing.
- When we create the Calendar entry from a Call, the Call’s Campaign, Medium, and Source data are not copied directly into the draft; instead, they only show up after saving the record.
This means the user sees empty fields and might think they need to fill them in manually—if their permissions allow it. Would it be possible to transfer these values upon creation of the record, without having to save it first?
Thank you very much!
11b1bf7 to
59d4b74
Compare
0e896ca to
4aa4297
Compare
4aa4297 to
59e38a1
Compare
javierizaca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a functional level everything works perfectly, the name of the module seems adequate to me since it aligns with the existing marketing_crm_partner
ValentinVinagre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes have been pushed to the main module, which isn't correct. Everything should be in the extension module.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
@HaraldPanten @javierizaca
This module extends calendar events by adding UTM tracking fields: campaign, source, and medium. It links calendar events to related CRM phonecalls automatically when created from a phonecall context, inheriting their UTM values. The calendar event views are customized to display these tracking fields in the form and tree views for better marketing analysis.
T-8642