[16.0][MIG] github_connector_odoo: Migration to version 16.0 #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinafernandez-tecnativa
force-pushed
the
16.0-mig-github_connector_odoo
branch
5 times, most recently
from
a7048c5 to
32efeb0
Compare
Member
|
Please rebase fixing conflicts. /ocabot migration github_connector_odoo |
[FIX] module icon resize problem
* [FIX] Fix field property The property is 'readony'. * [IMP]Get module icon from multiple sources Get the module icon from the following sources (in order): 1. From the first entry of the images tag from the manifest 2. From the static directory
* [ADD] github_connector_odoo: New field category_id [IMP] increase version number [FIX] Lints * [REF] removed unecessary variables. [FIX] Lints * [FIX] corrected version, since this update requires a module upgrade
* [IMP] Add try-except on branch analyze action Add try-except statements on analyze actions that could potentially crash the analyze process. * [REF] Fix error logging Changes include: - fix error values - use error instead of warning * [IMP] Fix error in analyze call Fix a programming mistake in the analyze call. By @RoelAdriaans * [IMP] Bump version number of github_connector Bump the version number of github_connector to '11.0.1.1.1'. * [IMP] Bump version number of github_connector Bump the version number of github_connector_odoo to '11.0.1.1.1'.
Set a default icon per module, when no icon is defined in that module. The default icon is the 'OCA cube', the icon is located in the module itself (in /data/oca.png).
…CA#30) * [FIX]do not delete module version if already exists and just update * [FIX]remove not needed code * [IMP] added clean odoo module version cron * [IMP]support module_paths also * [IMP]separate function fo the module path to remove redundant code
To play nice with Sentry.
There's a mix between self and branch arguments in analyze methods.
…functional This field allows to define where addons are located, but it's hidden right now, because not everything is properly adjusted for paths different from root. Making this working, there's no need to hide the field.
Putting fields.Image doesn't add value, as this is only for auto-resizing. The interesting thing is to add `attachment=True`, that allows to store the images as attachments and save space due to duplicates and lighten the DB size. Migration scripts included.
[UPD] Update github_connector_odoo.pot
github_connector_odoo 14.0.1.0.1
TT25583 [UPD] Update github_connector_odoo.pot [UPD] README.rst github_connector_odoo 14.0.2.0.0
… to _for_xml_id() github_connector_odoo 14.0.2.1.0
[FIX] github_connector_odoo: Correct pylint checks
…dule.version.rule.info
Do not create lines if no file has been scanned
carolinafernandez-tecnativa
force-pushed
the
16.0-mig-github_connector_odoo
branch
from
32efeb0 to
92dcfa5
Compare
Contributor
Author
done! |
pedrobaeza
requested review from
victoralmau
and removed request for
victoralmau
victoralmau
approved these changes
Mar 8, 2024
Member
victoralmau
left a comment
victoralmau
left a comment
There was a problem hiding this comment.
Code and functional review OK
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at 2c547e5. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TT45634
@Tecnativa
@pedrobaeza @victoralmau