[15.0][MIG] datamodel: Migration to 15.0 #222
Conversation
|
@yankinmax No time to debug, sorry. You should take a look at #218. odoo.addons.pydantic is far more powerfull and easier than datamodel. Moreover the way I implmented the extension capabilities of an existing pydantic model is more pythonic and allows type checking. No more need to get access to a registry to retrieve a model, you simply use your pydantic class as any common python class. |
lmignon
left a comment
lmignon
left a comment
There was a problem hiding this comment.
@yankinmax datamodels is not declared as installable https://github.com/yankinmax/rest-framework/blob/15.0-mig-datamodel/datamodel/__manifest__.py#L19
Does it change installable to False when using the migration procedure? |
yankinmax
force-pushed
the
15.0-mig-datamodel
branch
3 times, most recently
from
0c1c40b to
6279f18
Compare
[UPD] rest-framework conf to include datamodel
yankinmax
force-pushed
the
15.0-mig-datamodel
branch
from
6279f18 to
2781ba7
Compare
|
@lmignon can you pls take a look again here? It seems to be ok. |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
@lmignon your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-222-by-lmignon-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
@lmignon AFAIU @simahawk restarted the build and check passed. See here OCA/server-auth#310 (comment) |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at e87fd8d. Thanks a lot for contributing to OCA. ❤️ |
3 participants
No description provided.