[12.0][MIG+REF] auth_admin_passkey #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o login with any login and his password.
…ion if user_id == SUPERUSER_ID. (Courtesy of Stefan Rijnhart).
…s the same password as the admin user, sending a mail to admin user.
… installation of modules 'auth_admin_passkey' and 'auth_crypt'. (Courtesy of Stefan Rijnhart).
…xxx'] [REF] res_users.py : same call to self.pool in other res_users class.
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
this fixes an issue reported on Transifex
Remove authenticate as check_credentials is dedicated for this purpose. Removed mail translations maybe possible in some way ? Give some space to the code Make the addon compliant to OCA guidelines Adapt readme to new template and compress header in tests Make the addon a python package NOTE: authenticate() method cannot be used in tests because a new cr is created in _login method that does not contains our user. Signed-off-by: Eugen Don <eugen.don@don-systems.de>
… user email. If a normal user and the administrator have the same password, an AccessError is raised (email of the admin account can not be read) and no security alert is sent by email
* [FIX] AccessError sending mail
Currently translated at 90.9% (10 of 11 strings) Translation: server-tools-10.0/server-tools-10.0-auth_admin_passkey Translate-URL: https://translation.odoo-community.org/projects/server-tools-10-0/server-tools-10-0-auth_admin_passkey/pt/
[REF+IMP] move configuration for ir.config.parameter to odoo.cfg files, ref : OCA#21 So : - It's more GDPR compatible, because only system administrators that have already a full DB access can enable and use this feature - It's easier to have different settings, according to server env [REF] OCA convention (readme files, etc...)
|
Tested... 👍 . Thx for the work @legalsylvain |
Contributor
Author
|
Thanks for the reviews, guys. |
Contributor
Author
|
/ocabot merge |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
OCA-git-bot
added a commit
that referenced
this pull request
Oct 1, 2019
Contributor
|
Congratulations, your PR was merged at d55341b. Thanks a lot for contributing to OCA. ❤️ |
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-auth
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-auth (12.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port
auth_admin_passkeyfrom 10.0 to 12.0Main changes
odoo.cfgconfig file, and not byir.config.parametersettings. (more secure, more GDPR, and more simple code). Ref.CC : @pedrobaeza, @alexis-via, @rvalyi, @eugen-don, @rafaelbn
One question to @Fenkiou
You introduced the following code in that commit (PR to port the module in V10). I did'nt get this part. (I keep it, but I don't see it necessary).