-
-
Notifications
You must be signed in to change notification settings - Fork 492
[19.0][MIG] auth_ldaps: Migration to 19.0 #851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BT-vstoev
wants to merge
38
commits into
OCA:19.0
Choose a base branch
from
BT-vstoev:19.0-mig-auth_ldaps
base: 19.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (6 of 6 strings) Translation: server-auth-14.0/server-auth-14.0-auth_ldaps Translate-URL: https://translation.odoo-community.org/projects/server-auth-14-0/server-auth-14-0-auth_ldaps/it/
Currently translated at 100.0% (6 of 6 strings) Translation: server-auth-14.0/server-auth-14.0-auth_ldaps Translate-URL: https://translation.odoo-community.org/projects/server-auth-14-0/server-auth-14-0-auth_ldaps/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-15.0/server-auth-15.0-auth_ldaps Translate-URL: https://translation.odoo-community.org/projects/server-auth-15-0/server-auth-15-0-auth_ldaps/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+ Functional change: Handling the "Test Connection button":
test_ldap_connection- https://github.com/odoo/odoo/blob/19.0/addons/auth_ldap/models/res_company_ldap.py#L266confdict is constructed and then the_connectmethod is called directly with that dict.auth_ldapsmodule as we introduce new fields that should be part of the configuration for it.test_ldap_connectionmethod. This will work, but doesn't seem like a good practice.if conf.get("is_ssl")in the_connectmethod extension in auth_ldaps instead of the currentif conf["is_ssl"]:. This will obviously make the button "work", but actually it will not be performing a proper test of an SSL connection.. so technically - not work :)