-
-
Notifications
You must be signed in to change notification settings - Fork 201
[19.0][MIG] fs_storage Migration 19.0 #524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lmignon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @cyrilmanuel
|
This PR has the |
166a9b2 to
2cd2731
Compare
|
@lmignon sorry i miss something according to the migration steps (deprecated and optimization). Now it's good :) |
ce64891 to
361a226
Compare
lmignon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cyrilmanuel The addon is still marked as not installable 😿
f4b8017 to
32b2974
Compare
32b2974 to
508d396
Compare
CRogos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to restart following: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0
The commit history is not preserved.
|
Regarding commit history, the PR looks fine (19.0 was branched off 18.0, so only the migration commits appear here), but it misses a test-requirements.txt to reference the unmerged fs_storage PR. |
|
@cyrilmanuel can you add a |
508d396 to
11dce12
Compare
11dce12 to
b81cbdb
Compare
|
Did few fixes on cyrilmanuel#1 |
4535f5d to
c056b95
Compare
c056b95 to
a425761
Compare
fixup! [19.0][MIG] fs_storage Migration 19.0
|
@cyrilmanuel I finalized your PR into into #543. Thank you for your work. |
[19.0][MIG] fs_storage fixes
|
closed because superseed on #543 |
migration standard.