[14.0][IMP] endpoint: support usage of querystring parameters #80
Conversation
|
Hi @simahawk, |
dreispt
changed the title
|
Review is appreciated but please don't merge yet, there might be a few changes. |
dreispt
force-pushed
the
14-dr-endpoint-params
branch
from
d1bff46 to
3532d63
Compare
|
Ready for review. |
| * Response | ||
| * werkzeug | ||
| * exceptions | ||
| * params |
There was a problem hiding this comment.
| * params | |
| * querystring_params |
| ) | ||
|
|
||
| def _handle_exec__code(self, request): | ||
| def _handle_exec__code(self, request, params=None): |
There was a problem hiding this comment.
| def _handle_exec__code(self, request, params=None): | |
| def _handle_exec__code(self, request, querystring_params=None): |
| raise NotFound() | ||
| endpoint._validate_request(request) | ||
| result = endpoint._handle_request(request) | ||
| result = endpoint._handle_request(request, params=params) |
There was a problem hiding this comment.
| result = endpoint._handle_request(request, params=params) | |
| result = endpoint._handle_request(request, querystring_params=params) |
| if not self._code_snippet_valued(): | ||
| return {} | ||
| eval_ctx = self._get_code_snippet_eval_context(request) | ||
| eval_ctx["params"] = params or {} |
There was a problem hiding this comment.
| eval_ctx["params"] = params or {} | |
| eval_ctx["querystring_params"] = querystring_params or {} |
| ) | ||
|
|
||
| def _handle_request(self, request): | ||
| def _handle_request(self, request, params=None): |
There was a problem hiding this comment.
| def _handle_request(self, request, params=None): | |
| def _handle_request(self, request, querystring_params=None): |
| handler = self_with_user._get_handler() | ||
| try: | ||
| res = handler(request) | ||
| # In case the handler does not support params |
There was a problem hiding this comment.
I doubt we have any other handler ATM but just in case... ok, let's keep this but I would add a separated commit for backward compat that we can easily drop on migration.
Something like:
[imp] endpoint: support querystring params
[imp] endpoint: backward compat for querystring params
Old handlers might not accept this new kw args
Trash this commit in future versions. Eg: v18.
| if params: | ||
| res = handler(request, params=params) |
There was a problem hiding this comment.
| if params: | |
| res = handler(request, params=params) | |
| if querystring_params: | |
| res = handler(request, querystring_params=querystring_params) |
dreispt
force-pushed
the
14-dr-endpoint-params
branch
from
3532d63 to
f002179
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
dreispt
removed
the
stale
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
3 participants
No description provided.