Skip to content

enable -Wextra #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
akva2 wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

enable -Wextra #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55cfca0
enable -Wextra
akva2 Jul 1, 2019
51362f6
single build job for warning parsing purposes
akva2 Jul 2, 2019
c05f06f
ignore unused parameter warnings
akva2 Jul 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cmake/Modules/FindIFEMDeps.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,13 +276,17 @@ endif()

include(CheckCXXCompilerFlag)
check_cxx_compiler_flag(-Wall HAS_WALL)
check_cxx_compiler_flag(-Wextra HAS_WEXTRA)
check_cxx_compiler_flag(-Wno-parentheses HAS_PARENTHESES)
if(HAS_WALL)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall")
endif()
if(HAS_PARENTHESES)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-parentheses")
endif()
if(HAS_WEXTRA)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wextra -Wno-unused-parameter")
endif()

set(IFEM_REGTEST_SCRIPT ${IFEM_PATH}/Apps/Common/scripts/regtest.sh.in)
set(IFEM_CLANG_CHECK_TEST_SCRIPT ${IFEM_PATH}/Apps/Common/scripts/clang-check-test.sh.in)
Expand Down
2 changes: 1 addition & 1 deletion jenkins/build-ifem-module.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ function build_module {
cmake $3 -DCMAKE_BUILD_TYPE=Release $1
test $? -eq 0 || exit 1
# Threaded build
nproc=`nproc`
nproc=1 #`nproc`
if test $2 -eq 1
then
cmake --build . --target testapps -- -j$nproc
Expand Down